From be8a48769519b68b0c52705a2ba3dbd081717b11 Mon Sep 17 00:00:00 2001 From: Ossi Salmi Date: Tue, 13 Mar 2012 14:05:26 +0200 Subject: [PATCH 1/3] Added --remove-also to munin-node-configure --- munin/manifests/init.pp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/munin/manifests/init.pp b/munin/manifests/init.pp index 334220a..f4b02a9 100644 --- a/munin/manifests/init.pp +++ b/munin/manifests/init.pp @@ -52,7 +52,7 @@ class munin::node { } exec { "munin-node-configure": - command => "munin-node-configure --shell 2>/dev/null | /bin/sh", + command => "munin-node-configure --shell --remove-also 2>/dev/null | /bin/sh", path => "/bin:/usr/bin:/sbin:/usr/sbin:/usr/local/bin:/usr/local/sbin", user => root, refreshonly => true, From 6ed4c9aafd84e95d84b9da13424dd40677b2f7a3 Mon Sep 17 00:00:00 2001 From: Ossi Salmi Date: Tue, 13 Mar 2012 14:06:20 +0200 Subject: [PATCH 2/3] Added options parameter for network::vlan Allows adding VLAN interfaces to bridges. --- network/manifests/init.pp | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/network/manifests/init.pp b/network/manifests/init.pp index a955025..48f3d76 100644 --- a/network/manifests/init.pp +++ b/network/manifests/init.pp @@ -491,6 +491,8 @@ class network::helper::vlan { # - # $netmask: # - +# $options: +# - # # === Sample usage # @@ -500,7 +502,8 @@ class network::helper::vlan { # netmask => "255.255.0.0", # } # -define network::vlan($device, $ipaddr = "none", $netmask = "none") { +define network::vlan($device, $ipaddr = "none", $netmask = "none", + $options = []) { case $operatingsystem { openbsd: { network::interface { "vlan${name}": @@ -514,6 +517,7 @@ define network::vlan($device, $ipaddr = "none", $netmask = "none") { network::interface { "${device}.${name}": ipaddr => $ipaddr, netmask => $netmask, + options => $options, require => Augeas["enable-vlan-support"], } } From cc5af5dc4cca864ab716341efacfb965f103799f Mon Sep 17 00:00:00 2001 From: Ossi Salmi Date: Tue, 13 Mar 2012 14:15:49 +0200 Subject: [PATCH 3/3] Fixed OpenBSD service provider with YES/NO service flags --- custom/lib/puppet/provider/service/openbsd.rb | 17 +++++++++++------ 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/custom/lib/puppet/provider/service/openbsd.rb b/custom/lib/puppet/provider/service/openbsd.rb index dcf8044..0e0947c 100644 --- a/custom/lib/puppet/provider/service/openbsd.rb +++ b/custom/lib/puppet/provider/service/openbsd.rb @@ -65,13 +65,14 @@ Puppet::Type.type(:service).provide :openbsd, :parent => :base do def enabled? name = @resource[:name] rcvar = self.rcvar + rcvar_name = self.rcvar_name rcvar_value = self.rcvar_value pkg_scripts = self.pkg_scripts - if rcvar.nil? and not pkg_scripts.include?(name) - return :false - end - if rcvar_value.nil? or rcvar_value == "NO" - return :false + if rcvar_name.end_with?("_flags") + return :false if rcvar.nil? and not pkg_scripts.include?(name) + return :false if rcvar_value.nil? or rcvar_value == "NO" + else + return :false if rcvar_value != "YES" end :true end @@ -96,7 +97,11 @@ Puppet::Type.type(:service).provide :openbsd, :parent => :base do rcvar_value = start[/^#{binary}\s*(.*)/, 1] end end - s += "%s=\"%s\"\n" % [rcvar_name, rcvar_value] + if rcvar_name.end_with?("_flags") + s += "%s=\"%s\"\n" % [rcvar_name, rcvar_value] + else + s += "%s=YES\n" % rcvar_name + end pkg_scripts << name if rcvar.nil? and not pkg_scripts.include?(name) s += "pkg_scripts=\"%s\"\n" % pkg_scripts.join(" ") File.open(@@rcconf_local, "w") { |f| f << s }