Fixing puppet-lint errors.
This commit is contained in:
parent
2f83cb7d4a
commit
34c36045fa
59 changed files with 995 additions and 990 deletions
|
@ -4,39 +4,39 @@
|
|||
class iscsi::server {
|
||||
|
||||
package { "scsi-target-utils":
|
||||
ensure => installed,
|
||||
ensure => installed,
|
||||
}
|
||||
|
||||
service { "tgtd":
|
||||
ensure => running,
|
||||
enable => true,
|
||||
require => Package["scsi-target-utils"],
|
||||
ensure => running,
|
||||
enable => true,
|
||||
require => Package["scsi-target-utils"],
|
||||
}
|
||||
|
||||
file { "/etc/tgt/targets.conf":
|
||||
ensure => present,
|
||||
source => [ "puppet:///files/iscsi/targets.conf.${fqdn}",
|
||||
"puppet:///files/iscsi/targets.conf",
|
||||
"puppet:///modules/iscsi/targets.conf", ],
|
||||
mode => 0600,
|
||||
owner => root,
|
||||
group => root,
|
||||
require => Package["scsi-target-utils"],
|
||||
ensure => present,
|
||||
source => [ "puppet:///files/iscsi/targets.conf.${fqdn}",
|
||||
"puppet:///files/iscsi/targets.conf",
|
||||
"puppet:///modules/iscsi/targets.conf", ],
|
||||
mode => 0600,
|
||||
owner => root,
|
||||
group => root,
|
||||
require => Package["scsi-target-utils"],
|
||||
}
|
||||
|
||||
file { "/etc/tgt/target.d":
|
||||
ensure => directory,
|
||||
mode => 0700,
|
||||
owner => root,
|
||||
group => root,
|
||||
require => Package["scsi-target-utils"],
|
||||
ensure => directory,
|
||||
mode => 0700,
|
||||
owner => root,
|
||||
group => root,
|
||||
require => Package["scsi-target-utils"],
|
||||
}
|
||||
|
||||
exec { "iscsi-refresh":
|
||||
command => "tgt-admin -e",
|
||||
path => "/bin:/usr/bin:/sbin:/usr/sbin",
|
||||
onlyif => "tgt-admin -e -p | egrep '^tgtadm '",
|
||||
require => Service["tgtd"],
|
||||
command => "tgt-admin -e",
|
||||
path => "/bin:/usr/bin:/sbin:/usr/sbin",
|
||||
onlyif => "tgt-admin -e -p | egrep '^tgtadm '",
|
||||
require => Service["tgtd"],
|
||||
}
|
||||
|
||||
}
|
||||
|
@ -74,24 +74,24 @@ define iscsi::target($tid, $initiator = "ALL", $ensure = "present") {
|
|||
$iqn = sprintf("iqn.2005-08.tgt:%s%s", $hostname, regsubst($name, "/", ".", "G"))
|
||||
|
||||
case $ensure {
|
||||
"present": {
|
||||
file { "/etc/tgt/target.d/${tid}.conf":
|
||||
ensure => present,
|
||||
content => template("iscsi/tid.conf.erb"),
|
||||
mode => 0600,
|
||||
owner => root,
|
||||
group => root,
|
||||
require => File["/etc/tgt/target.d"],
|
||||
before => Exec["iscsi-refresh"],
|
||||
}
|
||||
|
||||
}
|
||||
"absent": {
|
||||
file { "/etc/tgt/target.d/${tid}.conf":
|
||||
ensure => absent,
|
||||
before => Exec["iscsi-refresh"],
|
||||
}
|
||||
}
|
||||
"present": {
|
||||
file { "/etc/tgt/target.d/${tid}.conf":
|
||||
ensure => present,
|
||||
content => template("iscsi/tid.conf.erb"),
|
||||
mode => 0600,
|
||||
owner => root,
|
||||
group => root,
|
||||
require => File["/etc/tgt/target.d"],
|
||||
before => Exec["iscsi-refresh"],
|
||||
}
|
||||
|
||||
}
|
||||
"absent": {
|
||||
file { "/etc/tgt/target.d/${tid}.conf":
|
||||
ensure => absent,
|
||||
before => Exec["iscsi-refresh"],
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
}
|
||||
|
@ -102,13 +102,13 @@ define iscsi::target($tid, $initiator = "ALL", $ensure = "present") {
|
|||
class iscsi::initiator {
|
||||
|
||||
package { "iscsi-initiator-utils":
|
||||
ensure => installed,
|
||||
ensure => installed,
|
||||
}
|
||||
|
||||
service { "iscsid":
|
||||
ensure => running,
|
||||
enable => true,
|
||||
require => Package["iscsi-initiator-utils"],
|
||||
ensure => running,
|
||||
enable => true,
|
||||
require => Package["iscsi-initiator-utils"],
|
||||
}
|
||||
|
||||
}
|
||||
|
@ -133,10 +133,10 @@ define iscsi::connect($portal) {
|
|||
include iscsi::initiator
|
||||
|
||||
exec { "iscsi-connect-${name}":
|
||||
path => "/bin:/usr/bin:/sbin:/usr/sbin",
|
||||
command => "iscsiadm --mode discovery --type sendtargets --portal ${portal} && iscsiadm --mode node --targetname ${name} --portal ${portal} --login && sleep 5",
|
||||
unless => "iscsiadm --mode session | egrep '${portal}:[0-9]*,[0-9]* ${name}'\$",
|
||||
require => Service["iscsid"],
|
||||
path => "/bin:/usr/bin:/sbin:/usr/sbin",
|
||||
command => "iscsiadm --mode discovery --type sendtargets --portal ${portal} && iscsiadm --mode node --targetname ${name} --portal ${portal} --login && sleep 5",
|
||||
unless => "iscsiadm --mode session | egrep '${portal}:[0-9]*,[0-9]* ${name}'\$",
|
||||
require => Service["iscsid"],
|
||||
}
|
||||
|
||||
}
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue