postfix: ansible-lint fixes

roles/postfix/handlers/main.yml

@@ -1,10 +1,10 @@
 ---
-- name: restart postfix
+- name: Restart postfix
-  service:
+  ansible.builtin.service:
     name: postfix
     state: restarted
 
-- name: restart stunnel-smtps
+- name: Restart stunnel-smtps
-  service:
+  ansible.builtin.service:
     name: stunnel-smtps
     state: restarted

roles/postfix/tasks/main.yml

@@ -1,135 +1,150 @@
 ---
-- name: check support
+- name: Install postfix
-  fail:
+  ansible.builtin.package:
-    msg: Role not supported in your system
-  when: ansible_os_family != "RedHat"
-
-- name: install postfix
-  package:
     name: postfix
     state: installed
 
-- name: set postfix as system mta
+- name: Set postfix as system mta
-  alternatives:
+  community.general.alternatives:
     name: mta
     path: /usr/sbin/sendmail.postfix
 
-- name: configure myhostname
+- name: Configure myhostname
-  lineinfile:
+  ansible.builtin.lineinfile:
     path: /etc/postfix/main.cf
     regexp: '^myhostname\s*='
     insertafter: '^#myhostname\s*='
     line: "myhostname = {{ inventory_hostname }}"
-  notify: restart postfix
+  notify: Restart postfix
 
-- name: configure myorigin
+- name: Configure myorigin
-  lineinfile:
+  ansible.builtin.lineinfile:
     path: /etc/postfix/main.cf
     regexp: '^myorigin\s*='
     insertafter: '^#myorigin\s*='
     line: "myorigin = {{ mail_domain }}"
-  notify: restart postfix
+  notify: Restart postfix
   when: mail_domain is defined
 
-- name: configure mydestination
+- name: Configure mydestination
-  lineinfile:
+  ansible.builtin.lineinfile:
     path: /etc/postfix/main.cf
     regexp: '^mydestination\s*='
     insertafter: '^#mydestination\s*='
     line: 'mydestination = ""'
-  notify: restart postfix
+  notify: Restart postfix
   when:
     - mail_domain is defined
     - mail_server is defined
 
-- block:
+- name: Install stunnel
-    - name: install stunnel
+  ansible.builtin.package:
-      package:
+    name: stunnel
-        name: stunnel
+    state: installed
-        state: installed
-
-    - name: create group smtps
-      group:
-        name: smtps
-        system: true
-
-    - name: create user smtps
-      user:
-        name: smtps
-        comment: Service Stunnel-SMTPS
-        createhome: false
-        group: smtps
-        home: /var/empty
-        shell: /sbin/nologin
-        system: true
-
-    - name: create stunnel config
-      template:
-        src: stunnel.conf.j2
-        dest: /etc/stunnel/smtps.conf
-        mode: 0644
-        owner: root
-        group: "{{ ansible_wheel }}"
-      notify: restart stunnel-smtps
-
-    - name: create stunnel systemd service
-      copy:
-        src: stunnel-smtps.service
-        dest: /etc/systemd/system/stunnel-smtps.service
-        mode: 0644
-        owner: root
-        group: "{{ ansible_wheel }}"
-      notify: restart stunnel-smtps
-
-    - name: enable stunnel service
-      service:
-        name: stunnel-smtps
-        state: started
-        enabled: true
-
-    - name: configure relayhost
-      lineinfile:
-        path: /etc/postfix/main.cf
-        regexp: '^relayhost\s*='
-        insertafter: '^#relayhost\s*='
-        line: "relayhost = [localhost]:2525"
-      notify: restart postfix
-
   when:
-    - ansible_distribution_major_version|int < 8
+    - ansible_distribution_major_version|int <= 7
     - mail_server is defined
 
-- block:
+- name: Create group smtps
-    - name: configure relayhost
+  ansible.builtin.group:
-      lineinfile:
+    name: smtps
-        path: /etc/postfix/main.cf
+    system: true
-        regexp: '^relayhost\s*='
+  when:
-        insertafter: '^#relayhost\s*='
+    - ansible_distribution_major_version|int <= 7
-        line: "relayhost = [{{ mail_server }}]:465"
+    - mail_server is defined
-      notify: restart postfix
 
-    - name: configure smtp_tls_security_level
+- name: Create user smtps
-      lineinfile:
+  ansible.builtin.user:
-        path: /etc/postfix/main.cf
+    name: smtps
-        regexp: '^smtp_tls_security_level\s*='
+    comment: Service Stunnel-SMTPS
-        insertafter: '^#?relayhost\s*='
+    createhome: false
-        line: "smtp_tls_security_level = encrypt"
+    group: smtps
-      notify: restart postfix
+    home: /var/empty
+    shell: /sbin/nologin
+    system: true
+  when:
+    - ansible_distribution_major_version|int <= 7
+    - mail_server is defined
 
-    - name: configure smtp_tls_wrappermode
+- name: Create stunnel config
-      lineinfile:
+  ansible.builtin.template:
-        path: /etc/postfix/main.cf
+    src: stunnel.conf.j2
-        regexp: '^smtp_tls_wrappermode\s*='
+    dest: /etc/stunnel/smtps.conf
-        insertafter: '^#?relayhost\s*='
+    mode: 0644
-        line: "smtp_tls_wrappermode = yes"
+    owner: root
-      notify: restart postfix
+    group: "{{ ansible_wheel }}"
+  notify: Restart stunnel-smtps
+  when:
+    - ansible_distribution_major_version|int <= 7
+    - mail_server is defined
 
+- name: Create stunnel systemd service
+  ansible.builtin.copy:
+    src: stunnel-smtps.service
+    dest: /etc/systemd/system/stunnel-smtps.service
+    mode: 0644
+    owner: root
+    group: "{{ ansible_wheel }}"
+  notify: Restart stunnel-smtps
+  when:
+    - ansible_distribution_major_version|int <= 7
+    - mail_server is defined
+
+- name: Enable stunnel service
+  ansible.builtin.service:
+    name: stunnel-smtps
+    state: started
+    enabled: true
+  when:
+    - ansible_distribution_major_version|int <= 7
+    - mail_server is defined
+
+- name: Configure relayhost
+  ansible.builtin.lineinfile:
+    path: /etc/postfix/main.cf
+    regexp: '^relayhost\s*='
+    insertafter: '^#relayhost\s*='
+    line: "relayhost = [localhost]:2525"
+  notify: Restart postfix
+  when:
+    - ansible_distribution_major_version|int <= 7
+    - mail_server is defined
+
+- name: Configure relayhost
+  ansible.builtin.lineinfile:
+    path: /etc/postfix/main.cf
+    regexp: '^relayhost\s*='
+    insertafter: '^#relayhost\s*='
+    line: "relayhost = [{{ mail_server }}]:465"
+  notify: Restart postfix
   when:
     - ansible_distribution_major_version|int >= 8
     - mail_server is defined
 
-- name: enable postfix service
+- name: Configure smtp_tls_security_level
-  service:
+  ansible.builtin.lineinfile:
+    path: /etc/postfix/main.cf
+    regexp: '^smtp_tls_security_level\s*='
+    insertafter: '^#?relayhost\s*='
+    line: "smtp_tls_security_level = encrypt"
+  notify: Restart postfix
+  when:
+    - ansible_distribution_major_version|int >= 8
+    - mail_server is defined
+
+- name: Configure smtp_tls_wrappermode
+  ansible.builtin.lineinfile:
+    path: /etc/postfix/main.cf
+    regexp: '^smtp_tls_wrappermode\s*='
+    insertafter: '^#?relayhost\s*='
+    line: "smtp_tls_wrappermode = yes"
+  notify: Restart postfix
+  when:
+    - ansible_distribution_major_version|int >= 8
+    - mail_server is defined
+
+- name: Enable postfix service
+  ansible.builtin.service:
     name: postfix
     state: started
     enabled: true