From b6bceb64a41e32068cd58d5c1183ecb47497a4e7 Mon Sep 17 00:00:00 2001 From: Timo Makinen Date: Fri, 4 Apr 2025 05:29:19 +0000 Subject: [PATCH] node_exporter: Use real tempfile --- .../files/node-exporter-run-textfile-collector.sh | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/roles/node_exporter/files/node-exporter-run-textfile-collector.sh b/roles/node_exporter/files/node-exporter-run-textfile-collector.sh index b8897ae..7a6d1a0 100755 --- a/roles/node_exporter/files/node-exporter-run-textfile-collector.sh +++ b/roles/node_exporter/files/node-exporter-run-textfile-collector.sh @@ -15,9 +15,10 @@ fi for script in /usr/local/libexec/node-exporter/*; do [ -x "$script" ] || continue target="${OUTDIR}/$(basename "$script")" - if "$script" > "${target}.tmp" ; then - mv "${target}.tmp" "${target}.prom" + tmpfile="$(mktemp -p "$OUTDIR")" + if "$script" > "$tmpfile" ; then + mv "$tmpfile" "$target" else - rm -f "${target}.tmp" + rm -f "$tmpfile" fi done