From 776b562abe9f6cacfebf687e8b570dce04b60704 Mon Sep 17 00:00:00 2001 From: Timo Makinen Date: Fri, 4 Apr 2025 16:01:43 +0000 Subject: [PATCH] routeros_firmware: Use real tmpfile --- .../files/download-routeros-firmware.sh | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/roles/routeros_firmware/files/download-routeros-firmware.sh b/roles/routeros_firmware/files/download-routeros-firmware.sh index 1cdbd53..96260ca 100644 --- a/roles/routeros_firmware/files/download-routeros-firmware.sh +++ b/roles/routeros_firmware/files/download-routeros-firmware.sh @@ -46,15 +46,16 @@ if [ -z "$checksum" ]; then fi echo "Downloading new package '${packagename}'" -trap 'rm -f -- "${packagename}.tmp"' EXIT -curl -sSf -o "${packagename}.tmp" "$packageurl" +tmpfile="$(mktemp -p .)" +trap 'rm -f -- "$tmpfile"' EXIT +curl -sSf -o "$tmpfile" "$packageurl" -if [ "$(sha256sum "${packagename}.tmp" | cut -d " " -f 1)" != "$checksum" ]; then +if [ "$(sha256sum "$tmpfile" | cut -d " " -f 1)" != "$checksum" ]; then echo "ERR: Checksum check failed, not saving package" 1>&2 exit 1 fi -mv "${packagename}.tmp" "$packagename" +mv "$tmpfile" "$packagename" echo curl -sSf "https://cdn.mikrotik.com/routeros/$(echo "$packagename" | cut -d "-" -f 2)/CHANGELOG"