From 6a0cca3298bfe70182641d3aa10ea60cdf70b297 Mon Sep 17 00:00:00 2001
From: Timo Makinen <tmakinen@foo.sh>
Date: Sat, 29 Oct 2022 18:56:19 +0000
Subject: [PATCH] mkhomedir: ansible-lint fixes

---
 roles/mkhomedir/handlers/main.yml |  4 ++--
 roles/mkhomedir/tasks/main.yml    | 23 ++++++++++++++---------
 2 files changed, 16 insertions(+), 11 deletions(-)

diff --git a/roles/mkhomedir/handlers/main.yml b/roles/mkhomedir/handlers/main.yml
index 5c41bb0..a2f8400 100644
--- a/roles/mkhomedir/handlers/main.yml
+++ b/roles/mkhomedir/handlers/main.yml
@@ -1,5 +1,5 @@
 ---
-- name: restart oddjobd
-  service:
+- name: Restart oddjobd
+  ansible.builtin.service:
     name: oddjobd
     state: restarted
diff --git a/roles/mkhomedir/tasks/main.yml b/roles/mkhomedir/tasks/main.yml
index c227044..7961019 100644
--- a/roles/mkhomedir/tasks/main.yml
+++ b/roles/mkhomedir/tasks/main.yml
@@ -1,22 +1,27 @@
 ---
-- name: install packages
-  package:
+- name: Install packages
+  ansible.builtin.package:
     name: oddjob-mkhomedir
     state: installed
 
-- name: get current state of authselect
-  shell: /usr/bin/authselect current --raw ; /bin/true
+- name: Get current state of authselect
+  ansible.buitlin.shell:
+    cmd: /usr/bin/authselect current --raw ; /bin/true
   register: result
   check_mode: false
   changed_when: false
 
-- name: enable mkhomedir
-  command: /usr/bin/authselect enable-feature with-mkhomedir
+- name: Enable mkhomedir
+  ansible.builtin.command:
+    argv:
+      - /usr/bin/authselect
+      - enable-feature
+      - with-mkhomedir
   when: "'with-mkhomedir' not in result.stdout"
-  notify: restart oddjobd
+  notify: Restart oddjobd
 
-- name: enable oddjobd service
-  service:
+- name: Enable oddjobd service
+  ansible.builtin.service:
     name: oddjobd
     state: started
     enabled: true