tftp: ansible-lint fixes

roles/tftp/tasks/main.yml

@@ -1,41 +1,45 @@
 ---
-- block:
+- name: Install packages
-  - name: install packages
+  ansible.builtin.package:
-    package:
+    name: tftp-server
-      name: tftp-server
+    state: installed
-      state: installed
-
-  - name: create group tftpd
-    group:
-      name: tftpd
-      system: true
-
-  - name: create user tftpd
-    user:
-      name: tftpd
-      comment: Service TFTP
-      createhome: false
-      group: tftpd
-      home: /var/empty
-      shell: /sbin/nologin
-      system: true
-
-  - name: set selinxu context for data directory
-    sefcontext:
-      path: "/export/tftpboot(/.*)?"
-      setype: tftpdir_rw_t
   when: ansible_os_family != "OpenBSD"
 
-- name: create data directory
+- name: Create group tftpd
-  file:
+  ansible.builtin.group:
+    name: tftpd
+    system: true
+  when: ansible_os_family != "OpenBSD"
+
+- name: Create user tftpd
+  ansible.builtin.user:
+    name: tftpd
+    comment: Service TFTP
+    createhome: false
+    group: tftpd
+    home: /var/empty
+    shell: /sbin/nologin
+    system: true
+  when: ansible_os_family != "OpenBSD"
+
+- name: Set SELinux context for data directory
+  community.general.sefcontext:
+    path: "/export/tftpboot(/.*)?"
+    setype: tftpdir_rw_t
+  when:
+    - ansible_system == "Linux"
+    - ansible_selinux.status != "disabled"
+
+- name: Create data directory
+  ansible.builtin.file:
     path: /export/tftpboot
     state: directory
     mode: 0755
     owner: root
     group: "{{ ansible_wheel }}"
 
-- name: link data directory
+- name: Link data directory
-  file:
+  ansible.builtin.file:
     dest: /srv/tftpboot
     src: /export/tftpboot
     state: link
@@ -43,36 +47,37 @@
     group: "{{ ansible_wheel }}"
     follow: false
 
-- block:
+- name: Create drop-in directory for service
-  - name: create drop-in directory for service
+  ansible.builtin.file:
-    file:
+    path: /etc/systemd/system/tftp.service.d
-      path: /etc/systemd/system/tftp.service.d
+    state: directory
-      state: directory
+    mode: 0755
-      mode: 0755
+    owner: root
-      owner: root
+    group: "{{ ansible_wheel }}"
-      group: "{{ ansible_wheel }}"
-
-  - name: create service add-on config
-    copy:
-      dest: /etc/systemd/system/tftp.service.d/local.conf
-      content: |
-        [Service]
-        ExecStart=
-        ExecStart=/usr/sbin/in.tftpd -s /srv/tftpboot -u tftpd -c -v
-      mode: 0644
-      owner: root
-      group: "{{ ansible_wheel }}"
-    notify: restart tftpd
-
-  - name: enable service
-    systemd:
-      name: tftp.socket
-      enabled: true
-      state: started
   when: ansible_service_mgr == "systemd"
 
-- name: enable service
+- name: Create service add-on config
-  service:
+  ansible.builtin.copy:
+    dest: /etc/systemd/system/tftp.service.d/local.conf
+    content: |
+      [Service]
+      ExecStart=
+      ExecStart=/usr/sbin/in.tftpd -s /srv/tftpboot -u tftpd -c -v
+    mode: 0644
+    owner: root
+    group: "{{ ansible_wheel }}"
+  notify: restart tftpd
+  when: ansible_service_mgr == "systemd"
+
+- name: Enable service
+  ansible.builtin.systemd:
+    name: tftp.socket
+    enabled: true
+    state: started
+  when: ansible_service_mgr == "systemd"
+
+- name: Enable service
+  ansible.builtin.service:
     name: tftpd
     enabled: true
     state: started