tftp: ansible-lint fixes

roles/tftp/tasks/main.yml

@@ -1,17 +1,18 @@
 ---
-- block:
+- name: Install packages
-  - name: install packages
+  ansible.builtin.package:
-    package:
     name: tftp-server
     state: installed
+  when: ansible_os_family != "OpenBSD"
 
-  - name: create group tftpd
+- name: Create group tftpd
-    group:
+  ansible.builtin.group:
     name: tftpd
     system: true
+  when: ansible_os_family != "OpenBSD"
 
-  - name: create user tftpd
+- name: Create user tftpd
-    user:
+  ansible.builtin.user:
     name: tftpd
     comment: Service TFTP
     createhome: false
@@ -19,23 +20,26 @@
     home: /var/empty
     shell: /sbin/nologin
     system: true
-
-  - name: set selinxu context for data directory
-    sefcontext:
-      path: "/export/tftpboot(/.*)?"
-      setype: tftpdir_rw_t
   when: ansible_os_family != "OpenBSD"
 
-- name: create data directory
+- name: Set SELinux context for data directory
-  file:
+  community.general.sefcontext:
+    path: "/export/tftpboot(/.*)?"
+    setype: tftpdir_rw_t
+  when:
+    - ansible_system == "Linux"
+    - ansible_selinux.status != "disabled"
+
+- name: Create data directory
+  ansible.builtin.file:
     path: /export/tftpboot
     state: directory
     mode: 0755
     owner: root
     group: "{{ ansible_wheel }}"
 
-- name: link data directory
+- name: Link data directory
-  file:
+  ansible.builtin.file:
     dest: /srv/tftpboot
     src: /export/tftpboot
     state: link
@@ -43,17 +47,17 @@
     group: "{{ ansible_wheel }}"
     follow: false
 
-- block:
+- name: Create drop-in directory for service
-  - name: create drop-in directory for service
+  ansible.builtin.file:
-    file:
     path: /etc/systemd/system/tftp.service.d
     state: directory
     mode: 0755
     owner: root
     group: "{{ ansible_wheel }}"
+  when: ansible_service_mgr == "systemd"
 
-  - name: create service add-on config
+- name: Create service add-on config
-    copy:
+  ansible.builtin.copy:
     dest: /etc/systemd/system/tftp.service.d/local.conf
     content: |
       [Service]
@@ -63,16 +67,17 @@
     owner: root
     group: "{{ ansible_wheel }}"
   notify: restart tftpd
+  when: ansible_service_mgr == "systemd"
 
-  - name: enable service
+- name: Enable service
-    systemd:
+  ansible.builtin.systemd:
     name: tftp.socket
     enabled: true
     state: started
   when: ansible_service_mgr == "systemd"
 
-- name: enable service
+- name: Enable service
-  service:
+  ansible.builtin.service:
     name: tftpd
     enabled: true
     state: started