network: ansible-lint fixes

roles/network/handlers/main.yml

@@ -1,14 +1,18 @@
 ---
-- block:
+- name: Restart network
-  - name: restart network
+  ansible.builtin.command:
-    command: /bin/sh /etc/netstart
+    argv:
-  when: ansible_os_family == "OpenBSD"
+      - /bin/sh
+      - /etc/netstart
   
-- block:
+- name: Reload network manager connections
-  - name: reload network manager connections
+  ansible.builtin.command:
-    command: nmcli c reload
+    argv:
-  - name: restart keepalived
+      - nmcli
-    service:
+      - c
+      - reload
+
+- name: Restart keepalived
+  ansible.builtin.service:
     name: keepalived
     state: restarted
-  when: ansible_os_family == "RedHat"

roles/network/tasks/OpenBSD.yml

@@ -1,39 +1,41 @@
 ---
-
+- name: Create ethernet interface configurations
-- name: create ethernet interface configurations
+  ansible.builtin.template:
-  template:
     src: hostname.if.j2
     dest: "/etc/hostname.{{ item.device }}"
     mode: 0600
     owner: root
     group: "{{ ansible_wheel }}"
   with_items: "{{ network_interfaces }}"
-  notify: restart network
+  notify: Restart network
 
-- block:
+- name: Create carp interface configurations
-    - name: create carp interface configurations
+  ansible.builtin.template:
-      template:
     src: hostname.carp.j2
     dest: "/etc/hostname.carp{{ item.vhid }}"
     mode: 0600
     owner: root
     group: "{{ ansible_wheel }}"
   with_items: "{{ network_vip_interfaces }}"
-      notify: restart network
+  notify: Restart network
-    - name: enable carp preempt
+  when:
-      sysctl:
+    - network_vip_interfaces is defined
+    - network_vip_interfaces != []
+
+- name: Enable CARP preempt
+  ansible.posix.sysctl:
     name: net.inet.carp.preempt
     value: "1"
   when:
     - network_vip_interfaces is defined
     - network_vip_interfaces != []
 
-- name: set default gateway
+- name: Set default gateway
-  copy:
+  ansible.buitin.copy:
     content: "{{ network_default_gateway }}\n"
     dest: /etc/mygate
     mode: 0600
     owner: root
     group: "{{ ansible_wheel }}"
-  notify: restart network
+  notify: Restart network
   when: network_default_gateway is defined

roles/network/tasks/RedHat.yml

@@ -1,36 +1,48 @@
 ---
-- name: get interface uuid
+- name: Get interface uuid
-  command:
+  ansible.builtin.command:
-    cmd: nmcli -f "DEVICE,UUID,NAME" c show
+    argv:
+      - nmcli
+      - -f
+      - DEVICE,UUID,NAME
+      - c
+      - show
   changed_when: false
   check_mode: false
   register: interface_uuid
 
-- name: create ethernet interface configurations
+- name: Create ethernet interface configurations
-  template:
+  ansible.builtin.template:
     src: ifcfg-eth.j2
     dest: "/etc/sysconfig/network-scripts/ifcfg-{{ item.device }}"
     mode: 0644
     owner: root
     group: "{{ ansible_wheel }}"
-  notify: reload network manager connections
+  notify: Reload network manager connections
   with_items: "{{ network_interfaces }}"
 
-- block:
+- name: Install keepalived
-    - name: install keepalived
+  ansible.builtin.package:
-      package:
     name: keepalived
     state: installed
-    - name: create keepalived config
+  when:
-      template:
+    - network_vip_interfaces is defined
+    - network_vip_interfaces != []
+
+- name: Create keepalived config
+  ansible.builtin.template:
     dest: /etc/keepalived/keepalived.conf
     src: keepalived.conf.j2
     mode: 0600
     owner: root
     group: "{{ ansible_wheel }}"
-      notify: restart keepalived
+  notify: Restart keepalived
-    - name: enable keepalived
+  when:
-      service:
+    - network_vip_interfaces is defined
+    - network_vip_interfaces != []
+
+- name: Enable keepalived
+  ansible.builtin.service:
     name: keepalived
     state: started
     enabled: true

roles/network/tasks/main.yml

@@ -1,9 +1,9 @@
 ---
-- name: include os spcific tasks
+- name: Include OS spcific tasks
-  include_tasks: "{{ ansible_os_family }}.yml"
+  ansible.builtin.include_tasks: "{{ ansible_os_family }}.yml"
 
-- name: create resolv.conf
+- name: Create resolv.conf
-  template:
+  ansible.builtin.template:
     src: resolv.conf.j2
     dest: /etc/resolv.conf
     mode: 0644