network: ansible-lint fixes

roles/network/tasks/OpenBSD.yml

@@ -1,39 +1,41 @@
 ---
-
-- name: create ethernet interface configurations
-  template:
+- name: Create ethernet interface configurations
+  ansible.builtin.template:
     src: hostname.if.j2
     dest: "/etc/hostname.{{ item.device }}"
     mode: 0600
     owner: root
     group: "{{ ansible_wheel }}"
   with_items: "{{ network_interfaces }}"
-  notify: restart network
+  notify: Restart network
 
-- block:
-    - name: create carp interface configurations
-      template:
-        src: hostname.carp.j2
-        dest: "/etc/hostname.carp{{ item.vhid }}"
-        mode: 0600
-        owner: root
-        group: "{{ ansible_wheel }}"
-      with_items: "{{ network_vip_interfaces }}"
-      notify: restart network
-    - name: enable carp preempt
-      sysctl:
-        name: net.inet.carp.preempt
-        value: "1"
+- name: Create carp interface configurations
+  ansible.builtin.template:
+    src: hostname.carp.j2
+    dest: "/etc/hostname.carp{{ item.vhid }}"
+    mode: 0600
+    owner: root
+    group: "{{ ansible_wheel }}"
+  with_items: "{{ network_vip_interfaces }}"
+  notify: Restart network
   when:
     - network_vip_interfaces is defined
     - network_vip_interfaces != []
 
-- name: set default gateway
-  copy:
+- name: Enable CARP preempt
+  ansible.posix.sysctl:
+    name: net.inet.carp.preempt
+    value: "1"
+  when:
+    - network_vip_interfaces is defined
+    - network_vip_interfaces != []
+
+- name: Set default gateway
+  ansible.buitin.copy:
     content: "{{ network_default_gateway }}\n"
     dest: /etc/mygate
     mode: 0600
     owner: root
     group: "{{ ansible_wheel }}"
-  notify: restart network
+  notify: Restart network
   when: network_default_gateway is defined