From 3288f9ec5840282f69fcbf566041fc3e789423b5 Mon Sep 17 00:00:00 2001
From: Timo Makinen <tmakinen@foo.sh>
Date: Thu, 7 Mar 2024 07:17:17 +0000
Subject: [PATCH] routeros_firmware: Fix parsing mikrotik web page

---
 roles/routeros_firmware/files/download-routeros-firmware.sh | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/roles/routeros_firmware/files/download-routeros-firmware.sh b/roles/routeros_firmware/files/download-routeros-firmware.sh
index 4347526..e6a0b65 100644
--- a/roles/routeros_firmware/files/download-routeros-firmware.sh
+++ b/roles/routeros_firmware/files/download-routeros-firmware.sh
@@ -18,7 +18,11 @@ if [ $# -gt 0 ]; then
 fi
 
 packageurl="$(curl -sSf "https://mikrotik.com/download" | \
-    sed -n 's/.*<a href="\(.*routeros-[0-9\.]*-arm\.npk\)">.*/\1/p')"
+    sed -n 's/.*<a href="\(.*routeros-[0-9\.]*-arm\.npk\)"[> ].*/\1/p')"
+if [ -z "$packageurl" ]; then
+    echo "ERR: Got empty package URL, exiting" 1>&2
+    exit 1
+fi
 packagename="$(basename "$packageurl")"
 if [ -f "$packagename" ]; then
     "$verbose" && echo "Already up to date"