From 0eeed22092a7ed48f50120ad13d9fa4833d39f03 Mon Sep 17 00:00:00 2001
From: Timo Makinen <tmakinen@foo.sh>
Date: Fri, 21 Jun 2024 15:17:39 +0000
Subject: [PATCH] ldap_server: Style fixes for backup script

---
 roles/ldap_server/files/ldap-backup.sh | 15 ++++++++-------
 1 file changed, 8 insertions(+), 7 deletions(-)

diff --git a/roles/ldap_server/files/ldap-backup.sh b/roles/ldap_server/files/ldap-backup.sh
index d6a95d4..2e84891 100755
--- a/roles/ldap_server/files/ldap-backup.sh
+++ b/roles/ldap_server/files/ldap-backup.sh
@@ -16,19 +16,20 @@ BACKUPAGE="30"
 
 DATE="$(date '+%Y-%m-%d')"
 
+cd "$BACKUPDIR"
+
 ldapsearch -LLL -x -H ldapi:// -s base -b 'cn=Databases,cn=Monitor' \
     '(objectClass=*)' namingContexts | \
     sed -n 's/^namingContexts: \(.*\)/\1/p' | while read -r db ; do
-        [ "${db}" = "cn=config" ] && continue
-        if ! slapcat -f /etc/openldap/slapd.conf -b "${db}" 2> /dev/null | \
-            gzip > "${BACKUPDIR}/${db}.${DATE}.gz" ; then
+        [ "$db" = "cn=config" ] && continue
+        if ! slapcat -f /etc/openldap/slapd.conf -b "$db" 2> /dev/null | \
+            gzip > "${db}.${DATE}.gz"
+	then
             echo "ERR: Failed to backup database ${db}" 1>&2
             continue
         fi
 	chgrp backup "${BACKUPDIR}/${db}.${DATE}.gz"
 done
 
-cd ${BACKUPDIR} && {
-    find . -xdev -depth -mindepth 1 -maxdepth 1 -type f -mtime +${BACKUPAGE} \
-        -name '*.gz' -execdir rm -f -- {} \;
-}
+find . -xdev -depth -mindepth 1 -maxdepth 1 -type f -mtime +${BACKUPAGE} \
+     -name '*.gz' -execdir rm -f -- {} \;