Fixes for ansible-lint

cups/tasks/main.yml

@@ -3,9 +3,9 @@
   ansible.builtin.shell:
     cmd: localectl status | grep -E '^\s+LC_PAPER=fi_FI.UTF-8$'
   register: locale_check
+  changed_when: false
   failed_when: false
   check_mode: false
-  changed_when: false
 
 - name: Set system paper size to A4
   ansible.builtin.command:
@@ -13,6 +13,8 @@
       - localectl
       - set-locale
       - LC_PAPER=fi_FI.UTF-8
+  register: result
+  changed_when: result.rc == 0
   when: locale_check.rc != 0
 
 - name: Install packages
@@ -24,7 +26,7 @@
   ansible.builtin.file:
     path: /etc/cups
     state: directory
-    mode: 0755
+    mode: "0755"
     owner: root
     group: "{{ ansible_wheel }}"
 
@@ -36,6 +38,6 @@
       Encryption Required
       TrustOnFirstUse No
       ValidateCerts Yes
-    mode: 0644
+    mode: "0644"
     owner: root
     group: "{{ ansible_wheel }}"

firefox/tasks/main.yml

@@ -8,7 +8,7 @@
   ansible.builtin.file:
     path: /usr/lib64/firefox/defaults/preferences
     state: directory
-    mode: 0755
+    mode: "0755"
     owner: root
     group: "{{ ansible_wheel }}"
 
@@ -16,6 +16,6 @@
   ansible.builtin.copy:
     dest: /usr/lib64/firefox/defaults/preferences/00-foo.sh.js
     src: foo.sh.js
-    mode: 0644
+    mode: "0644"
     owner: root
     group: "{{ ansible_wheel }}"

git/tasks/main.yml

@@ -8,7 +8,7 @@
   ansible.builtin.template:
     dest: /etc/profile.d/git.sh
     src: git.sh.j2
-    mode: 0644
+    mode: "0644"
     owner: root
     group: root
 
@@ -16,6 +16,6 @@
   ansible.builtin.template:
     dest: /etc/profile.d/git.csh
     src: git.csh.j2
-    mode: 0644
+    mode: "0644"
     owner: root
     group: root

google_chrome/tasks/main.yml

@@ -17,7 +17,7 @@
   ansible.builtin.file:
     path: "{{ item }}"
     state: directory
-    mode: 0755
+    mode: "0755"
     owner: root
     group: root
   with_items:
@@ -28,7 +28,7 @@
   ansible.builtin.copy:
     dest: /etc/opt/chrome/policies/managed/foo.sh.json
     src: managed.json
-    mode: 0644
+    mode: "0644"
     owner: root
     group: root
 
@@ -36,7 +36,7 @@
   ansible.builtin.copy:
     dest: /etc/opt/chrome/policies/recommended/foo.sh.json
     src: recommended.json
-    mode: 0644
+    mode: "0644"
     owner: root
     group: root
 
@@ -44,7 +44,7 @@
   ansible.builtin.copy:
     dest: "/usr/local/bin/{{ item }}"
     src: "{{ item }}.sh"
-    mode: 0755
+    mode: "0755"
     owner: root
     group: "{{ ansible_wheel }}"
   with_items:

kerberos/tasks/main.yml

@@ -8,6 +8,6 @@
   ansible.builtin.template:
     dest: /etc/krb5.conf.d/realm.conf
     src: realm.conf.j2
-    mode: 0644
+    mode: "0644"
     owner: root
     group: "{{ ansible_wheel }}"

ldap/tasks/main.yml

@@ -8,7 +8,7 @@
   ansible.builtin.template:
     dest: /etc/openldap/ldap.conf
     src: ldap.conf.j2
-    mode: 0644
+    mode: "0644"
     owner: root
     group: "{{ ansible_wheel }}"
 
@@ -16,6 +16,6 @@
   ansible.builtin.template:
     dest: /root/.ldaprc
     src: ldaprc.j2
-    mode: 0600
+    mode: "0600"
     owner: root
     group: "{{ ansible_wheel }}"

lynx/tasks/main.yml

@@ -8,7 +8,7 @@
   ansible.builtin.copy:
     dest: /etc/lynx-site.cfg
     src: lynx-site.cfg
-    mode: 0644
+    mode: "0644"
     owner: root
     group: "{{ ansible_wheel }}"
 
@@ -16,6 +16,6 @@
   ansible.builtin.copy:
     dest: /usr/local/bin/html2text
     src: html2text.sh
-    mode: 0755
+    mode: "0755"
     owner: root
     group: "{{ ansible_wheel }}"

mutt/tasks/main.yml

@@ -8,7 +8,7 @@
   ansible.builtin.template:
     dest: /etc/Muttrc.local
     src: Muttrc.local
-    mode: 0644
+    mode: "0644"
     owner: root
     group: "{{ ansible_wheel }}"
 
@@ -16,6 +16,6 @@
   ansible.builtin.copy:
     dest: /usr/local/bin/mutt-folder
     src: mutt-folder.sh
-    mode: 0755
+    mode: "0755"
     owner: root
     group: "{{ ansible_wheel }}"

powertools_repo/tasks/main.yml

@@ -6,7 +6,6 @@
       - config-manager
       - --dump
       - powertools
-    warn: false
   changed_when: false
   register: result
 
@@ -17,5 +16,6 @@
       - config-manager
       - --set-enabled
       - powertools
-    warn: false
+  register: result
+  changed_when: result.rc == 0
   when: "'enabled = 1' not in result.stdout_lines"

thunderbird/tasks/main.yml

@@ -8,6 +8,6 @@
   ansible.builtin.copy:
     dest: /usr/lib64/thunderbird/defaults/pref/00-foo.sh.js
     src: foo.sh.js
-    mode: 0644
+    mode: "0644"
     owner: root
     group: "{{ ansible_wheel }}"