From 203d9bea62bb5fbe2e59585ac9950bac878b4aa3 Mon Sep 17 00:00:00 2001 From: Timo Makinen Date: Mon, 31 Oct 2022 17:06:50 +0000 Subject: [PATCH] ansible-lint fixes --- cups/tasks/main.yml | 10 +++++----- epel_repo/tasks/main.yml | 2 +- firefox/tasks/main.yml | 6 +++--- git/tasks/main.yml | 7 +++---- google_chrome/tasks/main.yml | 12 ++++++------ kerberos/tasks/main.yml | 4 ++-- ldap/tasks/main.yml | 7 +++---- lynx/tasks/main.yml | 6 +++--- mutt/tasks/main.yml | 6 +++--- nvidia_driver/tasks/main.yml | 2 +- opencollab/tasks/main.yml | 7 +++---- powertools_repo/tasks/main.yml | 4 ++-- rpmfusion_free_repo/tasks/main.yml | 8 ++++---- rpmfusion_nonfree_repo/tasks/main.yml | 8 ++++---- spotify/tasks/main.yml | 5 ++--- thinlinc/tasks/main.yml | 12 ++++++------ thunderbird/tasks/main.yml | 4 ++-- 17 files changed, 53 insertions(+), 57 deletions(-) diff --git a/cups/tasks/main.yml b/cups/tasks/main.yml index cc61c29..d2835f2 100644 --- a/cups/tasks/main.yml +++ b/cups/tasks/main.yml @@ -1,5 +1,5 @@ --- -- name: check paper size +- name: Check paper size ansible.builtin.shell: cmd: localectl status | grep -E '^\s+LC_PAPER=fi_FI.UTF-8$' register: locale_check @@ -7,7 +7,7 @@ check_mode: false changed_when: false -- name: set system paper size to a4 +- name: Set system paper size to A4 ansible.builtin.command: argv: - localectl @@ -15,12 +15,12 @@ - LC_PAPER=fi_FI.UTF-8 when: locale_check.rc != 0 -- name: install packages +- name: Install packages ansible.builtin.package: name: cups-client state: installed -- name: create config directory +- name: Create config directory ansible.builtin.file: path: /etc/cups state: directory @@ -28,7 +28,7 @@ owner: root group: "{{ ansible_wheel }}" -- name: create config +- name: Create config ansible.builtin.copy: dest: /etc/cups/client.conf content: | diff --git a/epel_repo/tasks/main.yml b/epel_repo/tasks/main.yml index 7f6f052..cb5a58c 100644 --- a/epel_repo/tasks/main.yml +++ b/epel_repo/tasks/main.yml @@ -1,5 +1,5 @@ --- -- name: enable epel repository +- name: Enable EPEL repository ansible.builtin.package: name: epel-release state: installed diff --git a/firefox/tasks/main.yml b/firefox/tasks/main.yml index 4bb064f..84a58f0 100644 --- a/firefox/tasks/main.yml +++ b/firefox/tasks/main.yml @@ -1,10 +1,10 @@ --- -- name: install packages +- name: Install packages ansible.builtin.package: name: firefox state: installed -- name: create preferences directory +- name: Create preferences directory ansible.builtin.file: path: /usr/lib64/firefox/defaults/preferences state: directory @@ -12,7 +12,7 @@ owner: root group: "{{ ansible_wheel }}" -- name: install default settings +- name: Install default settings ansible.builtin.copy: dest: /usr/lib64/firefox/defaults/preferences/00-foo.sh.js src: foo.sh.js diff --git a/git/tasks/main.yml b/git/tasks/main.yml index 7bf757a..f485620 100644 --- a/git/tasks/main.yml +++ b/git/tasks/main.yml @@ -1,11 +1,10 @@ --- - -- name: install git packages +- name: Install packages ansible.builtin.package: name: git state: installed -- name: create git config for sh based shells +- name: Create git config for sh based shells ansible.builtin.template: dest: /etc/profile.d/git.sh src: git.sh.j2 @@ -13,7 +12,7 @@ owner: root group: root -- name: create git config for csh based shells +- name: Create git config for csh based shells ansible.builtin.template: dest: /etc/profile.d/git.csh src: git.csh.j2 diff --git a/google_chrome/tasks/main.yml b/google_chrome/tasks/main.yml index 042e44c..067438d 100644 --- a/google_chrome/tasks/main.yml +++ b/google_chrome/tasks/main.yml @@ -1,5 +1,5 @@ --- -- name: enable google chrome repository +- name: Enable Google Chrome repository ansible.builtin.yum_repository: name: google-chrome baseurl: http://dl.google.com/linux/chrome/rpm/stable/x86_64 @@ -8,12 +8,12 @@ gpgkey: https://dl.google.com/linux/linux_signing_key.pub enabled: true -- name: "install google chrome" +- name: Install packages ansible.builtin.package: name: google-chrome-stable state: present -- name: "create google chrome policy directories" +- name: Create policy directories ansible.builtin.file: path: "{{ item }}" state: directory @@ -24,7 +24,7 @@ - /etc/opt/chrome/policies/managed - /etc/opt/chrome/policies/recommended -- name: "install google chrome managed settings" +- name: Install managed settings ansible.builtin.copy: dest: /etc/opt/chrome/policies/managed/foo.sh.json src: managed.json @@ -32,7 +32,7 @@ owner: root group: root -- name: "install google chrome recommended settings" +- name: Install recommended settings ansible.builtin.copy: dest: /etc/opt/chrome/policies/recommended/foo.sh.json src: recommended.json @@ -40,7 +40,7 @@ owner: root group: root -- name: install custom chrome startup scripts +- name: Install custom startup scripts ansible.builtin.copy: dest: "/usr/local/bin/{{ item }}" src: "{{ item }}.sh" diff --git a/kerberos/tasks/main.yml b/kerberos/tasks/main.yml index 3d18502..88cebd3 100644 --- a/kerberos/tasks/main.yml +++ b/kerberos/tasks/main.yml @@ -1,10 +1,10 @@ --- -- name: install kerberos client packages +- name: Install packages ansible.builtin.package: name: krb5-workstation state: installed -- name: configure kerberos client +- name: Create config ansible.builtin.template: dest: /etc/krb5.conf.d/realm.conf src: realm.conf.j2 diff --git a/ldap/tasks/main.yml b/ldap/tasks/main.yml index 17ad3e4..2fee01c 100644 --- a/ldap/tasks/main.yml +++ b/ldap/tasks/main.yml @@ -1,11 +1,10 @@ --- - -- name: install packages +- name: Install packages ansible.builtin.package: name: openldap-clients state: installed -- name: configure ldap client +- name: Create config ansible.builtin.template: dest: /etc/openldap/ldap.conf src: ldap.conf.j2 @@ -13,7 +12,7 @@ owner: root group: "{{ ansible_wheel }}" -- name: authenticate to ldap with host certs when running as root +- name: Authenticate to server with host certs when running as root ansible.builtin.template: dest: /root/.ldaprc src: ldaprc.j2 diff --git a/lynx/tasks/main.yml b/lynx/tasks/main.yml index 98d9e57..67acbde 100644 --- a/lynx/tasks/main.yml +++ b/lynx/tasks/main.yml @@ -1,10 +1,10 @@ --- -- name: install packages +- name: Install packages ansible.builtin.package: name: lynx state: installed -- name: create site configuration +- name: Create site configuration ansible.builtin.copy: dest: /etc/lynx-site.cfg src: lynx-site.cfg @@ -12,7 +12,7 @@ owner: root group: "{{ ansible_wheel }}" -- name: install html2text script +- name: Install html2text script ansible.builtin.copy: dest: /usr/local/bin/html2text src: html2text.sh diff --git a/mutt/tasks/main.yml b/mutt/tasks/main.yml index 1763d6f..e0777cb 100644 --- a/mutt/tasks/main.yml +++ b/mutt/tasks/main.yml @@ -1,10 +1,10 @@ --- -- name: install packages +- name: Install packages ansible.builtin.package: name: mutt state: installed -- name: install global configuration +- name: Install global configuration ansible.builtin.template: dest: /etc/Muttrc.local src: Muttrc.local @@ -12,7 +12,7 @@ owner: root group: "{{ ansible_wheel }}" -- name: install mutt-folder helper script +- name: Install mutt-folder helper script ansible.builtin.copy: dest: /usr/local/bin/mutt-folder src: mutt-folder.sh diff --git a/nvidia_driver/tasks/main.yml b/nvidia_driver/tasks/main.yml index 882d233..e9922a1 100644 --- a/nvidia_driver/tasks/main.yml +++ b/nvidia_driver/tasks/main.yml @@ -1,5 +1,5 @@ --- -- name: install drivers +- name: Install drivers ansible.builtin.package: name: "{{ item }}" state: installed diff --git a/opencollab/tasks/main.yml b/opencollab/tasks/main.yml index d045de0..7c1b7e0 100644 --- a/opencollab/tasks/main.yml +++ b/opencollab/tasks/main.yml @@ -1,6 +1,5 @@ --- - -- name: install dependencies +- name: Install dependencies ansible.builtin.package: name: "{{ item }}" state: installed @@ -8,14 +7,14 @@ - git - python3 -- name: copy package +- name: Copy package ansible.builtin.git: dest: /usr/local/src/opencollab repo: "https://github.com/graphingwiki/opencollab.git" umask: "0022" version: python3 -- name: install package +- name: Install package ansible.builtin.pip: name: /usr/local/src/opencollab umask: "0022" diff --git a/powertools_repo/tasks/main.yml b/powertools_repo/tasks/main.yml index a06b33f..d6985ca 100644 --- a/powertools_repo/tasks/main.yml +++ b/powertools_repo/tasks/main.yml @@ -1,5 +1,5 @@ --- -- name: check if repository is enabled +- name: Check if repository is enabled ansible.builtin.command: argv: - dnf @@ -10,7 +10,7 @@ changed_when: false register: result -- name: enable repository +- name: Enable repository ansible.builtin.command: argv: - dnf diff --git a/rpmfusion_free_repo/tasks/main.yml b/rpmfusion_free_repo/tasks/main.yml index c0b6c42..dc0e0e8 100644 --- a/rpmfusion_free_repo/tasks/main.yml +++ b/rpmfusion_free_repo/tasks/main.yml @@ -1,5 +1,5 @@ --- -- name: install rpm signing key +- name: Install RPM isigning key ansible.builtin.rpm_key: key: > {{ @@ -9,7 +9,7 @@ state: present when: 'ansible_distribution != "Fedora"' -- name: install rpm signing key +- name: Install RPM signing key ansible.builtin.rpm_key: key: > {{ @@ -18,7 +18,7 @@ state: present when: 'ansible_distribution == "Fedora"' -- name: enable repository +- name: Enable repository ansible.builtin.package: name: > {{ @@ -28,7 +28,7 @@ state: installed when: 'ansible_distribution != "Fedora"' -- name: enable repository +- name: Enable repository ansible.builtin.package: name: > {{ diff --git a/rpmfusion_nonfree_repo/tasks/main.yml b/rpmfusion_nonfree_repo/tasks/main.yml index a816b24..a7453cb 100644 --- a/rpmfusion_nonfree_repo/tasks/main.yml +++ b/rpmfusion_nonfree_repo/tasks/main.yml @@ -1,5 +1,5 @@ --- -- name: install rpm signing key +- name: Install RPM signing key ansible.builtin.rpm_key: key: > {{ @@ -9,7 +9,7 @@ state: present when: 'ansible_distribution != "Fedora"' -- name: install rpm signing key +- name: Install RPM signing key ansible.builtin.rpm_key: key: > {{ @@ -18,7 +18,7 @@ state: present when: 'ansible_distribution == "Fedora"' -- name: enable repository +- name: Enable repository ansible.builtin.package: name: > {{ @@ -28,7 +28,7 @@ state: installed when: 'ansible_distribution != "Fedora"' -- name: enable repository +- name: Enable repository ansible.builtin.package: name: > {{ diff --git a/spotify/tasks/main.yml b/spotify/tasks/main.yml index b103373..76a08d2 100644 --- a/spotify/tasks/main.yml +++ b/spotify/tasks/main.yml @@ -1,6 +1,5 @@ --- - -- name: enable repository +- name: Enable repository ansible.builtin.yum_repository: name: spotify baseurl: https://negativo17.org/repos/spotify/fedora-$releasever/x86_64/ @@ -9,7 +8,7 @@ gpgkey: https://negativo17.org/repos/RPM-GPG-KEY-slaanesh enabled: true -- name: install spotify +- name: Install Spotify ansible.builtin.package: name: spotify state: present diff --git a/thinlinc/tasks/main.yml b/thinlinc/tasks/main.yml index 982928a..054630f 100644 --- a/thinlinc/tasks/main.yml +++ b/thinlinc/tasks/main.yml @@ -1,5 +1,5 @@ --- -- name: install thinlinc repository +- name: Install ThinLinc repository ansible.builtin.yum_repository: name: thinlinc baseurl: "https://mirrors.foo.sh/thinlinc/{{ ansible_architecture }}" @@ -7,18 +7,18 @@ gpgcheck: false enabled: true -- name: install thinlinc client +- name: Intall packages ansible.builtin.package: name: thinlinc-client state: installed -- name: set default server name +- name: Set default server name ansible.builtin.lineinfile: path: /opt/thinlinc/etc/tlclient.conf regexp: '^SERVER_NAME=' line: "SERVER_NAME=shell.foo.sh" -- name: disable fullscreen mode +- name: Disable fullscreen mode ansible.builtin.lineinfile: path: /opt/thinlinc/etc/tlclient.conf regexp: '^{{ item }}=' @@ -27,13 +27,13 @@ - FULL_SCREEN_MODE - FULL_SCREEN_ALL_MONITORS -- name: set default screen size +- name: Set default screen size ansible.builtin.lineinfile: path: /opt/thinlinc/etc/tlclient.conf regexp: '^SCREEN_SIZE_SELECTION=' line: "SCREEN_SIZE_SELECTION=2" -- name: use kerberos authentication +- name: Use kerberos authentication ansible.builtin.lineinfile: path: /opt/thinlinc/etc/tlclient.conf regexp: '^AUTHENTICATION_METHOD=' diff --git a/thunderbird/tasks/main.yml b/thunderbird/tasks/main.yml index 59125bf..58d628c 100644 --- a/thunderbird/tasks/main.yml +++ b/thunderbird/tasks/main.yml @@ -1,10 +1,10 @@ --- -- name: install packages +- name: Install packages ansible.builtin.package: name: thunderbird state: installed -- name: install default settings +- name: Install default settings ansible.builtin.copy: dest: /usr/lib64/thunderbird/defaults/pref/00-foo.sh.js src: foo.sh.js