Add tests and fix structure to prevent errors

deploy.sh

@@ -30,4 +30,4 @@ if ! rpm -q ansible > /dev/null; then
 fi
 
 # run playbook
-ansible-playbook deploy.yml
+ansible-playbook playbooks/deploy.yml

playbooks/deploy.yml

@@ -7,7 +7,7 @@
   become_method: sudo
 
   vars_files:
-    - vars.yml
+    - ../vars/defaults.yml
 
   roles:
     - cups
@@ -45,7 +45,7 @@
                 '/dev/null chars=ascii_lowercase,digits length=4'
               )
             }}
-      when: hostname_check.stdout == ""
+      when: not hostname_check.stdout
 
     - name: remove unneeded packages
       ansible.builtin.package:

tests/00-selfsanity.sh

@@ -0,0 +1,7 @@
+#!/bin/sh
+
+set -eu
+
+cd "$(dirname "$0")"
+
+find . -maxdepth 1 -type f -name "*.sh" -print0 | xargs -0 -t -n 1 shellcheck --

tests/01-yamllint.sh

@@ -0,0 +1,6 @@
+#!/bin/sh
+
+cd "$(dirname "$0")/.." || exit 1
+
+find . -type f -name "*.yml" -not -path "./roles/*" -print0 | \
+    xargs -0 -t -n 1 yamllint -s --

tests/02-ansiblelint.sh

@@ -0,0 +1,6 @@
+#!/bin/sh
+
+cd "$(dirname "$0")/.." || exit 1
+
+find . -name "*.yml" -not -path "./roles/*" -print0 | \
+    xargs -0 -t -n 1 -- ansible-lint -x meta-no-info --

tests/Makefile

@@ -0,0 +1,4 @@
+.PHONY = all
+
+all:
+	@for x in *.sh ; do sh "$$x" || exit 1 ; done