From 14331459d92755662446ad72275472a78d1c9b4d Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Timo=20M=C3=A4kinen?= <tmakinen@foo.sh>
Date: Wed, 27 Nov 2024 17:56:07 +0200
Subject: [PATCH] Lint fixes

---
 playbooks/deploy.yml | 25 ++++++++++++++-----------
 1 file changed, 14 insertions(+), 11 deletions(-)

diff --git a/playbooks/deploy.yml b/playbooks/deploy.yml
index 0176f63..067c768 100644
--- a/playbooks/deploy.yml
+++ b/playbooks/deploy.yml
@@ -1,10 +1,10 @@
 ---
 
-- name: "deploy workstation"
+- name: Deploy workstation
   hosts: localhost
   connection: local
   become: true
-  become_method: sudo
+  become_method: ansible.builtin.sudo
 
   vars_files:
     - ../vars/defaults.yml
@@ -19,11 +19,12 @@
     - mutt
     - rpmfusion_nonfree_repo
     - spotify
+    - ssh_known_hosts
     - thinlinc
     - thunderbird
 
   tasks:
-    - name: check hostname
+    - name: Check hostname
       ansible.builtin.command:
         argv:
           - hostnamectl
@@ -32,7 +33,7 @@
       register: hostname_check
       changed_when: false
 
-    - name: set hostname
+    - name: Set random hostname
       ansible.builtin.command:
         argv:
           - hostnamectl
@@ -47,7 +48,7 @@
             }}
       when: not hostname_check.stdout
 
-    - name: remove unneeded packages
+    - name: Remove unneeded packages
       ansible.builtin.package:
         name: "{{ item }}"
         state: absent
@@ -56,7 +57,7 @@
         - mlocate
         - nano-default-editor
 
-    - name: install extra packages
+    - name: Install extra packages
       ansible.builtin.package:
         name: "{{ item }}"
         state: installed
@@ -75,20 +76,22 @@
         - virt-manager                   # manage virtual machines
         - yamllint                       # linter for yaml files
 
-    - name: check for nvidia gpu
+    - name: Check for NVIDIA GPU
       ansible.builtin.shell:
-        cmd: lspci -d '0x10de:' -n | grep -E '^[0-9]+:[0-9]+\.[0-9]+ 0300:'
+        cmd: |
+          set -o pipefail
+          lspci -d '0x10de:' -n | grep -E '^[0-9]+:[0-9]+\.[0-9]+ 0300:'
       register: nvidia_check
       failed_when: false
       check_mode: false
       changed_when: false
 
-    - name: install nvidia gpu drivers
+    - name: Install NVIDIA GPU drivers
       ansible.builtin.include_role:
         name: nvidia_driver
       when: nvidia_check.rc == 0
 
-    - name: hide grub menu during boot
+    - name: Hide GRUB menu during boot
       ansible.builtin.lineinfile:
         path: /etc/default/grub
         line: GRUB_TIMEOUT_STYLE=hidden
@@ -96,7 +99,7 @@
       notify: reconfigure grub
 
   handlers:
-    - name: reconfigure grub
+    - name: Reconfigure GRUB
       ansible.builtin.command:
         argv:
           - grub2-mkconfig